Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry 9 deprecated the priv key in the DSN #5

Merged
merged 3 commits into from
Dec 4, 2018

Conversation

francoishill
Copy link
Collaborator

Introduction

Give us a short description of what your pull request does

This PR removes the PrivateKey requirement in the DSN (from Sentry 9)

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #5 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   94.22%   94.22%   -0.01%     
==========================================
  Files          34       34              
  Lines         849      848       -1     
==========================================
- Hits          800      799       -1     
  Misses         29       29              
  Partials       20       20
Impacted Files Coverage Δ
dsn.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3c77b...42a6750. Read the comment docs.

Copy link
Member

@notheotherben notheotherben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @francoishill, appreciate you spending the time on this, just one quick change request if you don't mind (to keep the API backwards compatible) and then I'll get it merged.

dsn.go Outdated Show resolved Hide resolved
@notheotherben notheotherben merged commit 2d84dba into SierraSoftworks:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants