[ui] Run prettier over the codebase

[thomasdavis]

• Seems harmless, app builds, and tested a few things, everything seems fine.
• Some dist files got run over but there temp and should also be fine.
• I think everyone knows how to switch on prettier

[github-actions]

VUE_APP_DEPLOYMENT_TAG: sandpit
IPFS Hash: QmZFhMisEgxDHuXQZbhAkAbPboVmhVx3pNmQf5aUCAhzFN
URL: https://gateway.pinata.cloud/ipfs/QmZFhMisEgxDHuXQZbhAkAbPboVmhVx3pNmQf5aUCAhzFN

[codecov]

Codecov Report

Merging #946 (10b2cb7) into develop (fabf139) will decrease coverage by 0.17%.
The diff coverage is 64.78%.

@@             Coverage Diff             @@
##           develop     #946      +/-   ##
===========================================
- Coverage    67.81%   67.63%   -0.18%     
===========================================
  Files           76       76              
  Lines         3048     3059      +11     
  Branches       370      378       +8     
===========================================
+ Hits          2067     2069       +2     
- Misses         876      885       +9     
  Partials       105      105              

Flag	Coverage Δ
server	57.39% <ø> (ø)
ui	77.33% <64.78%> (-0.42%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
ui/core/src/api/ClpService/ClpService.ts	81.25% <ø> (ø)
.../core/src/api/EthbridgeService/EthbridgeService.ts	68.69% <0.00%> (ø)
ui/core/src/api/EthbridgeService/parseTxFailure.ts	0.00% <0.00%> (ø)
ui/core/src/api/EthereumService/EthereumService.ts	65.48% <ø> (ø)
ui/core/src/api/SifService/getKeplrProvider.ts	84.61% <ø> (ø)
ui/core/src/api/SifService/parseTxFailure.ts	90.90% <ø> (ø)
ui/core/src/api/utils/SifClient/SifClient.ts	44.44% <ø> (ø)
.../core/src/api/utils/SifClient/SifUnsignedClient.ts	50.00% <ø> (ø)
ui/core/src/api/utils/SifClient/toPool.ts	90.00% <ø> (ø)
ui/core/src/api/utils/SifClient/x/clp/index.ts	88.88% <ø> (ø)
... and 19 more

[ryardley]

Nice work! Will this fail the build if you commit a file that isn't run over with prettier?

[59023g]

Nice work! Will this fail the build if you commit a file that isn't run over with prettier?

I second this. Pre-commit hook?

[ryardley]

Is it a waste to make a whole flow for this? Would it be better if we just add it to yarn build in the ui?

[ryardley]

Also this is only running it on .js files

[59023g]

Yea. We should just run prettier before yarn build

[github-actions]

VUE_APP_DEPLOYMENT_TAG: sandpit
IPFS Hash: Qmcw8bkFtV116ortRkKgHCnVLPoze25Ls4qhaxUwc5Hzpg
URL: https://gateway.pinata.cloud/ipfs/Qmcw8bkFtV116ortRkKgHCnVLPoze25Ls4qhaxUwc5Hzpg

[ryardley]

Is the config this is working off in here? I can't seem to find it. Seems like this is adding the "arrowParens" option to the core lib but the config has not been edited?

[github-actions]

VUE_APP_DEPLOYMENT_TAG: sandpit
IPFS Hash: QmNoffWgJagJXKCECUE4nR3b9upWw3LdjZVAYmtwtMntxJ
URL: https://gateway.pinata.cloud/ipfs/QmNoffWgJagJXKCECUE4nR3b9upWw3LdjZVAYmtwtMntxJ

[github-actions]

VUE_APP_DEPLOYMENT_TAG: sandpit
IPFS Hash: QmcXrKv1nTMqedb2mEXZwcWtJRgojpDtZCNHeA6kbC8c3N
URL: https://gateway.pinata.cloud/ipfs/QmcXrKv1nTMqedb2mEXZwcWtJRgojpDtZCNHeA6kbC8c3N

[github-actions]

VUE_APP_DEPLOYMENT_TAG: sandpit
IPFS Hash: QmTTDesJ5t1ksuipztYqpyxpEEYErNeav8uuGkCvzTmjVu
URL: https://gateway.pinata.cloud/ipfs/QmTTDesJ5t1ksuipztYqpyxpEEYErNeav8uuGkCvzTmjVu

[github-actions]

VUE_APP_DEPLOYMENT_TAG: mainnet
IPFS Hash: QmX9mnUWnvH9wSnKohUw2xhVdKsAjR2V9c6WXB4mC58dp9
URL: https://gateway.pinata.cloud/ipfs/QmX9mnUWnvH9wSnKohUw2xhVdKsAjR2V9c6WXB4mC58dp9