Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for 3ds, sepa, merchant_profile, sent_address and received_address fields for fintech #65

Merged

Conversation

rsomavarapu-sift
Copy link
Contributor

Purpose

  • Add support for new Fintech API fields which can be used for various purposes in the future like feature extraction, reporting, workflow management, etc.

Technical Overview

  • Support for the following API fields is added
    • $merchant_profile complex field. This field contains the fields $merchant_id, $merchant_name, $merchant_address, and $merchant_category_code. Thiis field is supported in $create_order, $update_order, and $transaction events.
    • $status_3ds, $triggered_3ds, $merchant_initiated_transaction, $sent_address, and $received_address are supported in $transaction event.
    • $shortened_iban_first6, $shortened_iban_last4, and $sepa_direct_debit_mandate are supported in $transaction event and $payment_method field

Testing Plan

  • Updated unit tests

Deployment
(Once all the fintech-related changes are merged)

  • Publish to Maven Central
  • Create a GitHub release

Note - I will update the changelog during the last PR as it would cause conflicts now.

Copy link
Contributor

@natashasehgal natashasehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason some files are removed?

@rsomavarapu-sift
Copy link
Contributor Author

@natashasehgal I removed those files and added all those tests in CreateOrderEventTest.java as it is the convention we are following.

@rsomavarapu-sift rsomavarapu-sift force-pushed the merchant_profile_transaction_sepa_fintech_fields branch from 2c3ac46 to 1eab441 Compare October 12, 2021 00:56
@natashasehgal
Copy link
Contributor

@natashasehgal I removed those files and added all those tests in CreateOrderEventTest.java as it is the convention we are following.

Thanks for making those changes along with your fintech ones!

Copy link
Contributor

@natashasehgal natashasehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@michelgoldstein michelgoldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsomavarapu-sift rsomavarapu-sift merged commit 1a830b1 into master Oct 12, 2021
Copy link
Contributor

@vincent-sift vincent-sift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants