-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for 3ds, sepa, merchant_profile, sent_address and received_address fields for fintech #65
adding support for 3ds, sepa, merchant_profile, sent_address and received_address fields for fintech #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason some files are removed?
@natashasehgal I removed those files and added all those tests in |
2c3ac46
to
1eab441
Compare
Thanks for making those changes along with your fintech ones! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Technical Overview
$merchant_profile
complex field. This field contains the fields$merchant_id
,$merchant_name
,$merchant_address
, and$merchant_category_code
. Thiis field is supported in$create_order
,$update_order
, and$transaction
events.$status_3ds
,$triggered_3ds
,$merchant_initiated_transaction
,$sent_address
, and$received_address
are supported in$transaction
event.$shortened_iban_first6
,$shortened_iban_last4
, and$sepa_direct_debit_mandate
are supported in$transaction
event and$payment_method
fieldTesting Plan
Deployment
(Once all the fintech-related changes are merged)
Note - I will update the changelog during the last PR as it would cause conflicts now.