1375 overview querybuilder #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srikanthccv Could you please also have a look into this change when you get time? |
palashgdev
suggested changes
Jan 4, 2023
frontend/src/container/MetricsApplication/MetricsPageQueries/MetricsPageQueriesFactory.ts
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/OverviewQueries.ts
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/OverviewQueries.ts
Outdated
Show resolved
Hide resolved
srikanthccv
reviewed
Jan 6, 2023
frontend/src/container/MetricsApplication/MetricsPageQueries/MetricsPageQueriesFactory.ts
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/MetricsPageQueriesFactory.ts
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/MetricsPageQueriesFactory.ts
Outdated
Show resolved
Hide resolved
…hakraborty/signoz into 1375-overview-querybuilder
|
Kudos, SonarCloud Quality Gate passed!
|
|
Dependent on this PR also - #2056 |
palashgdev
previously approved these changes
Jan 18, 2023
srikanthccv
reviewed
Jan 18, 2023
frontend/src/container/MetricsApplication/MetricsApplication.factory.ts
Outdated
Show resolved
Hide resolved
srikanthccv
approved these changes
Jan 23, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
palashgdev
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this exercise, have moved Operations per sec and Error Percentage Graph in Overview Tab from promql to querybuilder
Close #1375