Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: tagFilteritems-refactored #2056

Merged
merged 5 commits into from
Jan 16, 2023
Merged

refactor: tagFilteritems-refactored #2056

merged 5 commits into from
Jan 16, 2023

Conversation

sf-pchakraborty
Copy link
Contributor

Modified the tagfilteritems in order to avoid duplicacy and added useMemo hook

@sf-pchakraborty
Copy link
Contributor Author

@srikanthccv Can you please have a look once ? I have refactored the code to avoid duplicacy of tagfilter items.

@sf-pchakraborty sf-pchakraborty mentioned this pull request Jan 16, 2023
Merged
@palashgdev palashgdev self-requested a review January 16, 2023 12:27
@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.3% 6.3% Duplication

@palashgdev palashgdev merged commit 972bf94 into SigNoz:develop Jan 16, 2023
@sf-pchakraborty sf-pchakraborty deleted the refactor-metrics-factoryquery branch January 26, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sf-pchakraborty @palashgdev