Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding Improvement #1635

Conversation

Imccccc
Copy link
Contributor

@Imccccc Imccccc commented Apr 15, 2023

Background

The original embedding function will cause whole process crash when OpenAI or Azure API returns Error. It is necessary to try a few times.

Changes

1. move embedding function into llm_utils
2. add try feature within embedding function

Documentation

It is an improvement for existing feature. I believe only the code review is necessary.

Test Plan

PR Quality Checklist

  • [ x ] My pull request is atomic and focuses on a single change.
  • [ x ] I have thoroughly tested my changes with multiple different prompts.
  • [ x ] I have considered potential risks and mitigations for my changes.
  • [ x] I have documented my changes clearly and comprehensively.
  • [ x ] I have not snuck in any "extra" small tweaks changes

I test

1. move embedding function into llm_utils
2. add try feature with in embedding function
nponeccop
nponeccop previously approved these changes Apr 15, 2023
@nponeccop
Copy link
Contributor

@Imccccc There are conflicts now

BillSchumacher
BillSchumacher previously approved these changes Apr 15, 2023
Fix trailing whitespace
@BillSchumacher BillSchumacher dismissed stale reviews from nponeccop and themself via 93b3e84 April 15, 2023 20:03
Fix blank lines.
@BillSchumacher BillSchumacher merged commit 898b7ee into Significant-Gravitas:master Apr 15, 2023
sindlinger pushed a commit to Orgsindlinger/Auto-GPT-WebUI that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants