Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function split_file from file_operations.py #4658

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Jun 11, 2023

Background

split_file is not in use since #4208, see #3757 (comment)

Changes

  • Remove split_file in file_operations.py
  • Remove unit test for split_file

Test Plan

x

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes.
  • I have run the following commands against my code to ensure it passes our linters:
    black .
    isort .
    mypy
    autoflake --remove-all-unused-imports --recursive --ignore-init-module-imports --ignore-pass-after-docstring autogpt tests --in-place

@vercel
Copy link

vercel bot commented Jun 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 0:16am

@Pwuts Pwuts changed the title y Remove unused function split_file from file_operations.py Jun 11, 2023
@Pwuts Pwuts changed the title Remove unused function split_file from file_operations.py Remove unused function split_file from file_operations.py Jun 11, 2023
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.19 ⚠️

Comparison is base (ff46c16) 70.15% compared to head (1e33476) 69.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4658      +/-   ##
==========================================
- Coverage   70.15%   69.96%   -0.19%     
==========================================
  Files          72       72              
  Lines        3598     3586      -12     
  Branches      572      569       -3     
==========================================
- Hits         2524     2509      -15     
- Misses        893      894       +1     
- Partials      181      183       +2     
Impacted Files Coverage Δ
autogpt/commands/file_operations.py 82.79% <ø> (-1.05%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 1e33476
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/648663a6be9ff200084f4025
😎 Deploy Preview https://deploy-preview-4658--auto-gpt-docs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel vercel bot temporarily deployed to Preview June 12, 2023 00:16 Inactive
@Auto-GPT-Bot
Copy link
Contributor

You changed AutoGPT's behaviour. The cassettes have been updated and will be merged to the submodule when this Pull Request gets merged.

@Pwuts Pwuts merged commit a9d177e into master Jun 12, 2023
@Pwuts Pwuts deleted the rm-split_file branch June 12, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants