-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annoncements / Polls #62
Comments
POLL Recently Cask broke for images < 24.4 (cask/cask#480). I have 3 options here:
My preference would go to 1 because I installed Cask for @DamienCassou, and he tells me he does not use Cask anymore. It also somewhat forces Cask on everyone and nowadays there are other package management tools. So, who uses Cask in my images? This would also allow to remove the |
ANNONCEMENT
|
I'm still using Cask for the tests of most of my Emacs projects, so I'd prefer 2). Not sure what's the state of Cask's development, but to my knowledge it still doesn't have any convenient alternatives. |
Philippe Vaucher writes:
So, here is the first poll:
Recently Cask broke for images < 24.4
(cask/cask#480). I have 3 options here:
1. Remove Cask for all images.
2. Remove Cask for images < 24.4.
3. Wait until the issue fixes itself in Cask.
My preference would go to 1 because I installed Cask for @DamienCassou, and
he tells me he does not use Cask anymore. It also somewhat forces Cask on
everyone and nowadays there are many other package management tools.
So, who uses Cask in my images? This would also allow to remove the `python`
dependency. If we remove Cask, who would like to keep the python dependency?
I personally still use cask, but I don't currently depend on these images (I
just went through all my projects) so removing them is fine from my point of
view. However, If I did use these packages it would be very frustrating to see
cask support simply dropped (with no upgrade path). Since this is an emacs
package (and not a python one) I would assume few would mind the removal of
python.
|
I don't use Cask and I don't use Emacs < 25.
What do you need that you find in Cask and not in makem.sh or eldev?
Anyone can install anything on top of a Docker image. That's what users of other build systems use. Keeping Cask in the images is convenient for the Cask users because it makes their builds faster. But not having Cask in the image doesn't mean there is nothing one can do to get it back. |
Thanks guys. I think this is enough evidence to keep Cask. I'll follow in the issue wether < 24.4 is still worth supporting (we don't support 23.4 already). |
I’m late to reply, but I stopped using Cask years ago, and I’m pretty sure I don’t support < 25 anymore either. |
@gonewest818: thanks, not caring about < 25 seems to be a trend here. Maybe in the future it makes sense to only support the latest version of each (e.g only |
I do still use the 23.4 image for some projects, but mostly because I've not been forced to stop. I've also stopped using Cask as I spent more time debugging that than working on my project. |
For my part, I'm just using my https://github.com/purcell/nix-emacs-ci/ with no Docker in sight, so I don't have a strong opinion on any of this, sorry. |
@purcell: feel free to unsubscribe 😉 I added you because I thought that you'd knew who to ping if I forgot someone 😅 |
Maaaaybe I could start thinking about maintaining @snogge: that said if you just use the base |
Thanks, @Silex to know this issue via ansi.el issue (I hopped some issues from the issue).
Recently, keg.el registered to MELPA. |
I base my own images on the non-cask version. You can see my fork here https://github.com/snogge/docker-emacs . I'm not up to date with the latest development on master. What I would like to do is to trigger a rebuild of my docker-files each time you push new images to dockerhub. So far I've not seen a way to do that, but I do very little work with docker so maybe I'm missing something obvious. |
@snogge: thanks for your example. Your |
How seamless is the transition from Cask to Keg? Cask also seems to be mostly elisp, with only the front-end script in Python; Keg is all elisp. |
The Keg and Cask files have differences in syntax, so a few changes are needed. |
For now, |
I still dream of using straight.el as a build tool somehow. I use Cask but only due to momentum on my older projects and it's slowly falling apart. Me and the other maintainers don't really put in the work anymore :/ I think the optimal solution would be to have a |
I would like that as well. See e.g. radian-software/straight.el#100. Half the time when I try to use Cask it just fails with an inscrutable package-archive-related error message and refuses to do anything. |
Btw, today there's also https://github.com/doublep/eldev (another Cask alternative). I've played with it a bit and it seems pretty solid so far. |
Yes I think I'll move toward that direction. |
I like that idea! |
For more Cask alternatives see https://github.com/vermiculus/emake.el and https://github.com/alphapapa/makem.sh . |
Note to self: also add |
Okay About the table, let's start with something like this:
Questions:
Keep in mind that this table makes sense to be presented like this, but in the real world it's the |
I use the alpine variants usually because they are smaller which makes everything faster and puts less pressure on the build server. I won't mind much if you get rid of all alpine variants though. I only care about
I don't use keg nor do I plan to use it. Thank you for your great work! |
Cask is not maintained and there are no more new feature additions. (I'm saying as the maintainer of cask.) |
FYI to others who may need to update their CI, you should migrate to using |
silex/emacs no longer provides old minor versions, so test_in_docker.sh and lint_in_docker.sh now test for only the latest minor version of each major versions. Silex/docker-emacs#62 (comment) .github/workflows/run-test.yml, which uses nix-emacs-ci via purcell/setup-emacs, still tests against older minor versions.
That would only happen for |
@raxod502: sorry I missed your earlier message, but I see you managed to adapt 😆 |
I'm not far from being able to switch to purcell's https://github.com/purcell/nix-emacs-ci This means that 32 bit support will be gone and I'm currently trying to keep X support. I'll ping you when it goes live so you can report breakage (if any). |
32 bit support was dropped, images use https://github.com/purcell/nix-emacs-ci, please report if anything breaks. |
Unfortunately `silex/emacs` no longer supports them. Silex/docker-emacs#62 (comment) Silex/docker-emacs@ed73680
Unfortunately `silex/emacs` no longer supports them. Silex/docker-emacs#62 (comment) Silex/docker-emacs@ed73680
Unfortunately `silex/emacs` no longer supports them. Silex/docker-emacs#62 (comment) Silex/docker-emacs@ed73680
Unfortunately `silex/emacs` no longer supports them. Silex/docker-emacs#62 (comment) Silex/docker-emacs@ed73680
Unfortunately `silex/emacs` no longer supports them. Silex/docker-emacs#62 (comment) Silex/docker-emacs@ed73680
Hello, Apparently giflib 4 support was dropped (https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/aliases.nix#L378), which means 23.4 X support will be complicated. Then 25.3 now refuse to build on arm64 because I'll try to build it "vanilla" like purcell does, but that means that X support will be gone 😢 |
Ok I disabled X for 23.4 only, and disabled arm64 for 25.3 (see #85). |
The server that was lended to me to build arm64 images won't be available anymore in a while. If you are using the arm64 images please make some noise so we figure a way to maintain them. |
@NicolasPetton and I have stopped depending on these images. Thank you very much for maintaining them for so long! We are very grateful. |
Not using it myself, but AFAIK, Docker build and push Github Actions can trivially build multi arch images, arm64 included. Won't it be of any help? |
Also not using them myself, but I wonder if people using M1 Macs might have need of them? |
The problem is not getting an arm64 box for free, the problem is getting one where you can disable ASLR (moby/moby#22801, #38) to build Emacs < 28. |
You're correct. I guess I could try the QEMU route once more to check the latest version, but if it fails I just give up. |
It still does not build properly with QEMU, so I removed all arm64 images for now. |
I don't think it should be a tragedy, as I believe on the M1 macs you can still run x86 images, it is just using some emulation which degrades performance. And it seems unlikely that performance is of critical concern for Emacs inside Docker. |
There's an issue with manual builds of nix-emacs-ci so I dropped X support for now and use nix-emacs-ci directly. I'm considering doing that anyway because not many people seems to care about X support and it speeds image build time, also it solves the problem of outdated master images. |
I'll also remove dev images they feel uselesss. Basically now it's |
Following on the "wrap |
Hello!
@DamienCassou, @NicolasPetton, @gonewest818, @jgkamat, @dpsutton, @raxod502, @justinbarclay, @bbatsov, @purcell, @Fuco1
First of all, sorry for the notification. This is my attempt at solving the recurrent pattern of me asking you guys what you want. Futur annoncements / polls will be done here, so you can simply unsubscribe from this issue if you don't want me to ping you from time to time.
Please don't hesitate to
@someone
the ones I forgot or point them here (so they can subscribe to the issue), I'm only semi-aware of where my images are used.The text was updated successfully, but these errors were encountered: