GH-40: MAX_PING_TIME_INTERVAL should be 24 hours, 24 not minutes #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkljajic
added a commit
to nkljajic/UnifySDK
that referenced
this pull request
Apr 24, 2024
…ing-node-max-ping-interval
|
Please rebase you should see only one commit at: |
…inutes In ver_1.0.0 intended value was supposed to be 24 hours, as indicated by its comment. During refactoring this comment was lost, so value incorrectly remained 24 minutes. Interval of 24 minutes to ping failing device seems arbitrary and too short. Signed-off-by: Nenad Kljajic <nkljajic@control4.com>
nkljajic
force-pushed
the
bugfix/GH-40-fix-failing-node-max-ping-interval
branch
from
ea6217f
to
d04f193
Compare
|
Integration in progress |
|
Origin-SiliconLabs: ver_1.6.0-unstable-65-g0ffc592b27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ver_1.0.0 intended value was supposed to be 24 hours, as indicated by its comment. During refactoring this comment was lost, so value incorrectly remained 24 minutes. Interval of 24 minutes to ping failing device seems arbitrary and too short.