Dev 381 bulk download python add start d #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thf24
requested changes
Apr 4, 2023
simfin/utils.py
Outdated
| datareader = csv.reader(csvfile, delimiter=';', quotechar='"') | ||
| for k, row in enumerate(datareader): | ||
| if k > 0: | ||
| date = datetime.strptime(str(row[5]), '%Y-%m-%d') |
There was a problem hiding this comment.
its not always the 5th index, for share prices its not. So you have to look at the columns (in the first row), search for column name (only once at the beginning) either: "Report Date" or "Date" and take that index
simfin/utils.py
Outdated
| ########################################################################## | ||
|
|
||
| def into_date(date): |
simfin/utils.py
Outdated
| raise Exception("filters date not in format") | ||
|
|
||
|
|
||
| def condition_function(start_date=None, end_date=None): |
simfin/utils.py
Outdated
| return None | ||
|
|
||
|
|
||
| def filtered_file(dataset_path, start_date=None, end_date=None): |
| with open(dataset_path) as csvfile: | ||
| datareader = csv.reader(csvfile, delimiter=';', quotechar='"') | ||
| for k, row in enumerate(datareader): | ||
| if k > 0: |
There was a problem hiding this comment.
you have to write the first row also (without filtering) otherwise the rest doesnt work anymore
thf24
requested changes
Apr 13, 2023
simfin/utils.py
Outdated
| if rd_col in row: | ||
| index = row.index(rd_col) | ||
| elif d_col in row: | ||
| index = row.index(rd_col) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests
If you want to make contributions to this project, then please open an
issue on GitHub and discuss them prior to opening a pull request. It is
possible that the work is already in progress, or that there are certain
problems you need to take into account.
Before opening a pull request, please post a link to a GitHub gist with a
Python Notebook that includes your proposed code along with a working
example, and an explanation why that feature is useful.
Please ensure that your code is of very high quality, well-documented,
well-tested, and in the same polished style as the rest of this project.
Otherwise we may reject the pull request.