Create example subsystem

[HoodieRocks]

Description

This pull request adds an example subsystem for students to use to learn about how subsystems and commands are used in a robot environment.

Fixes #18

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation, if any
• My changes generate no new warnings
• I have performed tests that prove my fix is effective or that my feature works, if necessary
• New and existing unit tests pass locally with my changes

[HoodieRocks]

I realized after making the first commit that I committed the entire thing in one commit. Next time I plan to make smaller commits.

I believe the formatting failed because it expected the JDK 11 and below style case statements.

[IanTapply22]

I realized after making the first commit that I committed the entire thing in one commit. Next time I plan to make smaller commits.

I believe the formatting failed because it expected the JDK 11 and below style case statements.

Nope, it should expect the Java 17 style case statements :)

[IanTapply22]

Just made a couple of reviews regarding comments and some nitpicks at your code. Be sure to resolve these before requesting another round of reviews please.

[colemacphail]

Left a few comments. Generally solid, mostly code quality issues I'm spotting. Good job!

[IanTapply22]

Please use this when referencing the intake motor variable.

[IanTapply22]

Be sure to use this with referencing the PDP :)

[IanTapply22]

Just some little nit picks. Wait for @colemacphail's review and I want to go over it again after he does. Don't merge yet :)

[colemacphail]

1 nit and 2 questions about whether some code is right. Other than Ian's comments and failing CI, lgtm

[IanTapply22]

Resolve the above and I'll take one last look and give my stamp of approval!

[IanTapply22]

I would recommend on top of my suggestions here just going through the comments and see if they make sense. I just feel like some of the wording for these just feels a little bit off and doesn't really make sense in relation to what the code is doing.

[IanTapply22]

Just another thing I'm noticing as well, be sure that when you're writing a commit message you use the following conventions. The main thing is to use a capital letter for every first letter in the first word in a commit message and to be brief and concise.

This project will be going public once everything is finalized and I want to make sure that we're professional with everything as much as possible.

https://www.gitkraken.com/learn/git/best-practices/git-commit-message
https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53

[HoodieRocks]

I didn't see this message until after I pushed this commit. I'll keep this in mind next time!

[IanTapply22]

LGTM! Just gonna wait for @colemacphail to approve though.

Good job on this subtask!

[IanTapply22]

@colemacphail do we want to merge this now? The branch is updated and everything looks resolved and good to go. I saw some talk about a different strategy for the intake so I'm just unsure what's happening here.

[colemacphail]

Just another thing I'm noticing as well, be sure that when you're writing a commit message you use the following conventions. The main thing is to use a capital letter for every first letter in the first word in a commit message and to be brief and concise.

This project will be going public once everything is finalized and I want to make sure that we're professional with everything as much as possible.

https://www.gitkraken.com/learn/git/best-practices/git-commit-message https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53

Gonna point out that this doesn't really matter since the commit messages on main will be the PR description

That being said, keeping commit messages concise and accurate can help in cases like if you need to roll back a commit or look at what changes were made to solve what problem (both maybe more common than you'd think), so you should still be writing good commit messages.

[colemacphail]

fyi @IanTapply22 @HoodieRocks

Not gonna say we need to do this (especially not now, I want this PR in and project relatively done), but I saw this video recently and thought it was cool. Might be relevant here if we want to decouple this behaviour from the subsystems and make things a little clearer.

More reading if you're interested
Java-specific example
(That website saved me in my fourth-year software architecture courses btw -- strongly recommend skimming some of the design patterns if you have time)