Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option ISO_TP_USER_SEND_CAN_ARG #36

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

driftregion
Copy link
Contributor

add option ISO_TP_USER_SEND_CAN_ARG which includes an additional void* argument in isotp_user_send_can with which to pass adapter-specific information.

argument in isotp_user_send_can with which to pass adapter-specific
information.
Copy link
Owner

@SimonCahill SimonCahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM so far!

Can you add the changes to the README and maybe also add a Cmake option? Could be something like isotp_ENABLE_CAN_SEND_ARG which then #defines the directive?

SimonCahill
SimonCahill previously approved these changes Aug 16, 2024
@SimonCahill SimonCahill self-assigned this Aug 16, 2024
@SimonCahill SimonCahill added the enhancement New feature or request label Aug 16, 2024
@SimonCahill SimonCahill merged commit 276549c into SimonCahill:master Aug 16, 2024
2 checks passed
@SimonCahill
Copy link
Owner

Thanks!

I've added you to the list of contributors and bumped up the version; you can checkout the latest tag :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants