This repository was archived by the owner on Dec 26, 2017. It is now read-only.
Fixed the typo in the serializer #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to wait for main library to be updated first. |
|
@lakiboy Yes! Feel free to review they main library merge request. |
Nyholm
reviewed
May 2, 2017
| private $type; | ||
|
|
||
| public function __construct(MessageInEnvelopSerializer $serializer, Producer $bernard, RoutingKeyResolver $queueResolver, $type) | ||
| public function __construct(MessageInEnvelopeSerializer $serializer, Producer $bernard, RoutingKeyResolver $queueResolver, $type) |
There was a problem hiding this comment.
This will be a BC break, right?
One may say that a bundles BC promise only include a service's public methods. Im not sure how this is defined in the SimpleBus project. Here is an example: http://docs.php-http.org/en/latest/httplug/backwards-compatibility.html#symfony-bundle
There was a problem hiding this comment.
With the drop of the old PHP versions i'm looking into releasing al new marjor versions I think in that case this wound be a problem right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/SimpleBus/Serialization/issues/4