Stuff #3377
Merged
Stuff #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MissAllSunday
commented
Apr 2, 2016
MissAllSunday
commented
- fixes an issue with minify changing vars making unable to collapse categories
- Change code in Sources/ModerationCenter.php to be php 5.3 compatible
- renamed a few vars to avoid possible var name collision.
- Move a check for atachment previous, prevents undefined errors if no attachment was found.
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
making smf_setThemeOption() to save the wrong var Signed-off-by: Jessica González <suki@missallsunday.com>
fixes SimpleMachines#3376 Signed-off-by: Jessica González <suki@missallsunday.com>
| $smcFunc['db_free_result']($get_owner); | ||
|
|
||
| $note_owner = $note_owner['id_member']; |
There was a problem hiding this comment.
Oh wait... that entire line shouldn't be there unless you get rid of list().
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
fixes SimpleMachines#3381 Signed-off-by: Jessica González <suki@missallsunday.com>
|
Is this okay to get merged? |
Signed-off-by: Jessica González <suki@missallsunday.com>
|
not yet sadly, still need to push some more stuff |
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
This was referenced Apr 12, 2016
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Signed-off-by: Jessica González <suki@missallsunday.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.