[3.0] Implement a Mail Agent #7882
Open
+945
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
live627
reviewed
Nov 14, 2023
|
I'm going to need a cs fixer as between my own job's coding styles and personal preferences, I will have trouble to start with remembering these. Most of these issues you pointed out are present in the Cache API implantation as well. As evident from my copy and paste operations. |
Not surprising. I didn't get rigorous about updating the formatting until partway through the refactoring process. Sometime soon-ish I will submit a PR to clean up the formatting everywhere. |
jdarwood007
force-pushed
the
MailAgent
branch
from
a8a1da2
to
430dba8
Compare
|
Hello , your title has virus. 🤣 |
|
Who needs grammar? |
|
Everyone.
…On Wed, Jan 3, 2024 at 5:46 PM Jeremy D ***@***.***> wrote:
Who needs grammar?
—
Reply to this email directly, view it on GitHub
<#7882 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNNYJK5FGGUNZ2ZKCQM3YMX3URAVCNFSM6AAAAAA7J6JYUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWGE3DANJZG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sesquipedalian
requested changes
Jan 11, 2024
jdarwood007
force-pushed
the
MailAgent
branch
2 times, most recently
from
5870e92
to
01a65cd
Compare
jdarwood007
force-pushed
the
MailAgent
branch
5 times, most recently
from
9a697f6
to
5ec6aaa
Compare
jdarwood007
force-pushed
the
MailAgent
branch
from
5ec6aaa
to
1202f8a
Compare
APIs our Mail sending so 3rd party agents could process mail.
jdarwood007
force-pushed
the
MailAgent
branch
from
1202f8a
to
5e83f77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIs our Mail sending so 3rd party agents could process mail.
I haven't built the upgrade logic yet. Sesquipedalian had plans for improving that. So I'm not certain if we want to do that yet.This adds the always send a message-id that 2.1 has a PR for: 7843