Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language strings too fine-grained in default theme's forum statistics #1872

Closed
texttheater opened this issue Jun 22, 2014 · 6 comments
Closed

Comments

@texttheater
Copy link

The issue is with this line in Themes/default/BoardIndex.template.php:

', $context['common_stats']['total_posts'], ' ', $txt['posts_made'], ' ', $txt['in'], ' ', $context['common_stats']['total_topics'], ' ', $txt['topics'], ' ', $txt['by'], ' ', $context['common_stats']['total_members'], ' ', $txt['members'], '. ', !empty($settings['show_latest_member']) ? $txt['latest_member'] . ': <strong> ' . $context['common_stats']['latest_member']['link'] . '</strong>' : '', '<br />

Correct translation to, say, German is impossible because a different inflected form of $txt['members'] is required in this context than in others. I guess the whole message should be a single string.

This has been discussed before, and similar issues have apparently been resolved in other places: http://dev.simplemachines.org/mantis/view.php?id=4822

@MissAllSunday
Copy link
Contributor

Would merging all the text strings into a single one and use sprintf() work for you? I know it will work for Spanish.

Something like:

$txt['blabla'] = '%1$d Posts in %2$d Topics by %3$d Members - Latest Member %4$s'

@Dragooon
Copy link
Contributor

That's what I was thinking as well

@texttheater
Copy link
Author

Yes, that would work.

@Oldiesmann
Copy link
Contributor

Sounds good to me as well.

@MissAllSunday
Copy link
Contributor

It seems this has already been solved:

c99b41d

or is there another place where the sprintf() needs to be applied?

@texttheater
Copy link
Author

Oh, you're right! I was looking at the 2.0.8 sources. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants