Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SimpyCode to function offline #38

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Allow SimpyCode to function offline #38

merged 5 commits into from
Jul 17, 2024

Conversation

Potherca
Copy link
Member

@Potherca Potherca commented Jul 7, 2024

Currently, CodeMirror is loaded through a CDN.

This MR adds the CodeMirror version that is currently loaded through a CDN, 5.65.2, through package.json.

A post-install script is added that placed the relevant files in the js/ directory, in a separate codemirror/ folder.
In order to support alpine-based docker images (which only support sh/busybox), this script is as simple as possible.

As an actual dependency is added, the package-lock.json has also been committed.

@Potherca Potherca requested a review from ylebre July 7, 2024 15:30
@Potherca Potherca merged commit 7843812 into main Jul 17, 2024
2 checks passed
@Potherca Potherca deleted the fix/codemirror branch July 17, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants