Use Union Find algorithm in subst #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (Var v, _) -> putRT rt {env = Map.insert v ts' env} | ||
| (_, Var v) -> putRT rt {env = Map.insert v ts env} | ||
| (Var v, _) -> putRT rt {env = Partition.joinElems (Var v) ts' env} | ||
| (_, Var v) -> putRT rt {env = Partition.joinElems (Var v) ts env} | ||
| _ -> empty -- ts /= ts', both are values | ||
|
|
||
| -- | Apply the current substitution on the given 'Term'. This function does path compression: if it |
There was a problem hiding this comment.
This function does path compression: if it finds a variable, it recurs.
This statement is half true, it does recur, but it does not update the environment to compress the path. This PR tries to address that using the union find algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks don't show any improvement but it's worth investigating using union find to shorten the substitution paths in
subst.