Add PSE halo2 template to CLI #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiemckeon
commented
May 16, 2024
src/cli/init.ts
Outdated
| "_", | ||
| )}::circuit_def::CircuitInput`; | ||
| const className = `${packageName.replace(/-/g, "_")}${circuitPath}`; | ||
| templatePath = `${templatePath}/${halo2Version}`; |
There was a problem hiding this comment.
I am simultaneously aware I am offending all sorts of typing rules here, and unsure how to fix it. Would appreciate guidance. (You are also welcome to step in here and directly push edits to init.ts if you don't like the templatePath route)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces another template circuit for the PSE v0.3.0 Halo2 version we now support. Since Axiom v0.3.0 is equally likely to be of interest to users, I did not decide to replace that template. Rather we now have two choices for Halo2.
This complicates our template locations a little bit. Please determine if you are okay with the way I did that (
templatePathis a new variable that usually equalscircuitType, except in the case of Halo2, where it becomes$circuitType/$halo2Version.)I have tested existing frameworks to ensure the introduction of
templatePathdid not effect support for those. I also ransindri deployandsindri proof createon both Halo2 templates to ensure correctness.