Fix multiple deploy tag handling in the CLI with an explicit project directory #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--tagoption onsindri deploywas defined as a variadic option<tag...>which allowed specifying multiple tags. This created a problem when the optional positional argument for the project directory was also specified because it would be interpreted as an additional tag. For example,sindri deploy -t v1.0.0 my-circuitwould treat bothv1.0.0andmy-circuitas tags while using the default.as the project directory.This PR fixes the handling so that you need to repeat the tag argument for each tag and the project directory is no longer consumed as a tag. So you can now do
sindri deploy -t v1.0.0 -t latest my-circuitand havev1.0.0andlatesttreated as tags whilemy-circuitis the project directory.