-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed search field in controls loosing the text when window is resized #44
base: 1.17
Are you sure you want to change the base?
Conversation
Patched minecraft's scroll speed limitation
@Environment(EnvType.CLIENT) | ||
public class VersionedLogicMethodHelper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this branch able to run on all the supported Minecraft versions (1.14-1.17)?
If not then this class should come in a separate pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not test it with versions other than 1.17.1. But I do not expect the logic for item dropping and mouse scrolling to change in versions down to 1.8. But that should be checked to be sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just discovered that drop logic changed a little bit from mc 1.14 to 1.15 and is now bytecode incompatible with the newer versions. But I will fix it. It make 1.17 the base/compile version and call the 1.14 version's variant via reflection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the 1.14 logic and call the method via reflection. But I did not test it with a mc 1.14 version yet. You could test it when backporting to 1.14
return ((i % m) + m) % m; | ||
} | ||
|
||
// TODO: add scroll speed gui setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this is a todo :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely something for a future pr
No description provided.