Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening window when another window is in fullscreen #431

Closed
Kaligule opened this issue Jan 4, 2016 · 5 comments · Fixed by #433
Closed

opening window when another window is in fullscreen #431

Kaligule opened this issue Jan 4, 2016 · 5 comments · Fixed by #433

Comments

@Kaligule
Copy link
Contributor

Kaligule commented Jan 4, 2016

When there is a window in fullscreen and another one is created (for example bz pressing mod+enter), there is nothing to see (No problem here until here).
When exiting the fullscreen window (mod+f), suddenly the other window is in fullscreen. When leaving this fullscreen (mod+f again), the first window goes up in fullscreen, again.

So it is not really possible to directly leave fullscreenmode, only by moving a window to another workspace or quiting it.
This is reproducible on sway version f69d765 (2016-01-02, branch "master") on Arch linux.

@crondog
Copy link

crondog commented Jan 4, 2016

Ok I can reproduce your issue. When you have term1 opened in fullscreen mode, then open term2 it gets put behind term1, however term2 has focus. This means that when you press mod+f it is fullscreening term2.

Not sure what the best way to handle this situation is. I tested this in i3 and found that if i have a fullscreen term, I am unable to spawn a new term. I don't really agree with that.

Two alternatives that I can see are: If in fullscreen mode, make the new view have fullscreen or if in fullscreen return focus to the original fullscreen view.

@ddevault
Copy link
Contributor

ddevault commented Jan 4, 2016

return focus to the original fullscreen view

this

@StephenBrown2
Copy link
Contributor

Should this also make the spawned window "urgent" (or would it do that naturally), so that one knows a new window hasn't been lost when in fullscreen mode?

@ddevault
Copy link
Contributor

ddevault commented Jan 4, 2016

Wayland has no concept of urgency so I want to hold off on all related features for now.

crondog pushed a commit to crondog/sway that referenced this issue Jan 4, 2016
This fixes swaywm#431 by returning
focus to the fullscreen view. Also it fixes the issue with the
fullscreen view pointer not being set which did my head in
@Kaligule
Copy link
Contributor Author

Kaligule commented Jan 5, 2016

I tested this in i3 and found that if i have a fullscreen term, I am unable to spawn a new term.

Thats doesn't hold for my setup (Arch Linux, i3 version 4.11). When I'm in fullscreen and I open a new term, it is opened in the background and the fullscreen window persists.

The commit #433 solved that issue for me by implementing the exact same bahaviour. Thanks a lot.

ajouellette pushed a commit to ajouellette/sway that referenced this issue Jan 28, 2016
This fixes swaywm#431 by returning
focus to the fullscreen view. Also it fixes the issue with the
fullscreen view pointer not being set which did my head in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants