Big improvements to the client list #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirLagz
approved these changes
Aug 3, 2023
|
Hopefully the code rollback didn't create too many headaches for you. I
wanted to try out my new approach and needed a known starting point.
…On Thu, Aug 3, 2023 at 9:52 AM Lawrence ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#10 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG3DMON44TWL3K5YI3LQIX3XTO3KZANCNFSM6AAAAAA24MOY54>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
All good mate, just a few minutes with the conflict resolver and it was all sorted :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to roll back your preliminary wrapper code to do testing but hopefully it won't prove too difficult to integrate back into what you're doing.
I separated out the IP verification into a function and added some more features/bug fixes. Then integrated it into one other spot were IPs are entered.
I also reworked the handling of parsing the client list. It now runs all parsing operations in tandem and just re-collates the results after they arrive. Loading time for a list of any length is now a couple of seconds.