Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Linux bootstrap: Musl compat and no implicit GCC assumption #66

Merged
merged 5 commits into from
Jul 20, 2024

Conversation

vazub
Copy link

@vazub vazub commented May 2, 2024

  • Don't assume GCC by default, prefer giving user an option of setting CC env variable with Make invocation.
  • Define -D_LARGEFILE64_SOURCE, for better compat with Musl, as per https://wiki.musl-libc.org/faq

vazub added 2 commits May 2, 2024 11:05
- Don't assume GCC by default, prefer giving user an option of setting CC env variable with Make invocation. 
- Define -D_LARGEFILE64_SOURCE, for better compat with Musl, as per https://wiki.musl-libc.org/faq
Since CC is not hardcoded anymore, it is up to the caller to mention what exact compiler to use.
@vazub
Copy link
Author

vazub commented May 2, 2024

Ah, it just occurred to me, that since I suggested to change the example in README, it implicitly means other .mk files need to be adjusted as well, if this example is to be valid. Or, adjusting the readme, to specifically mention that CC invocation works for linux-x64 version only.

@Oldes Oldes merged commit c7a5df6 into Siskin-framework:bootstrap Jul 20, 2024
@Oldes
Copy link

Oldes commented Jul 20, 2024

It should be noted, that this branch is only to make a bootstrap version, it is not preferred way to build Rebol! But it is true, that I should improve the Siskin Builder tool to be able override settings like which compiler to use without need to modify the configuration (nest) files.

@Oldes
Copy link

Oldes commented Jul 20, 2024

Any idea how to make it the most user friendly?

@Oldes
Copy link

Oldes commented Jul 20, 2024

Also I'm not sure how useful is the _LARGEFILE64_SOURCE define... Rebol is limited to 32bit series! I'm not sure if I want to enlarge it, because it would also enhance memory usage. And to be honest, I never needed it... although it could be needed later as I start playing with video, where large files are expected... on the other side, one don't want to load complete video into a memory, so still no need to have 64bit series addressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants