Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-react] [ErrorBoundaries] Added unit tests to cover withPlaceholder HOC #1829

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jun 21, 2024

Description / Motivation

  • Introduced unit tests for withPlaceholder HOC to cover ErrorBoundaries functionality
  • Removed extra/invalid shapes of data (with/without params data). Since params property doesn't affect Placeholder functionality, unless it has FieldNames)

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team June 21, 2024 05:26
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
There is only one thing - not connected with this PR but wanted to mention - EditMode import seems to be not needed in withPlaceholder.test.tsx

@illiakovalenko illiakovalenko merged commit 0df6867 into dev Jul 1, 2024
1 check was pending
@illiakovalenko illiakovalenko deleted the feature/JSS-3433 branch July 1, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants