Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parallel Identical Query Tests. #119

Merged
merged 5 commits into from
Sep 5, 2020

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Sep 5, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Adding tests to prove AsyncKeyLock works and that #118 was due to a testing issue.

@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #119 into master will increase coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   86.89%   87.98%   +1.09%     
==========================================
  Files          44       44              
  Lines        1190     1190              
  Branches      164      164              
==========================================
+ Hits         1034     1047      +13     
+ Misses        106       97       -9     
+ Partials       50       46       -4     
Flag Coverage Δ
#unittests 87.98% <ø> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp.Web/FormatUtilities.cs 100.00% <ø> (ø)
src/ImageSharp.Web/Caching/Doorman.cs 100.00% <0.00%> (+20.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c2cb6...12c566d. Read the comment docs.

@JimBobSquarePants JimBobSquarePants requested a review from a team September 5, 2020 19:10
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0 milestone Sep 5, 2020
@JimBobSquarePants JimBobSquarePants merged commit aa1b192 into master Sep 5, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/prove-asynlock-works branch September 5, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants