Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #1505 #1506

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Fix for Issue #1505 #1506

merged 3 commits into from
Jan 15, 2021

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This fixes an Issue when creating the palette: Instead of this.maxColors, the constant QuantizerConstants.MaxColors was used (which can be bigger than maxColors).

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #1506 (b3146a7) into master (da7a8b7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1506   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files         741      741           
  Lines       32672    32672           
  Branches     3662     3662           
=======================================
  Hits        27289    27289           
  Misses       4669     4669           
  Partials      714      714           
Flag Coverage Δ
unittests 83.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Processors/Quantization/OctreeQuantizer{TPixel}.cs 95.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7a8b7...b3146a7. Read the comment docs.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks for getting this fixed so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants