-
-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Extract/Clone apis for manipulating deconstructing images from from #344
Conversation
The Frame suffix seems nice and explicit to me but I don't think that the APIs should live in the ImageFrameCollection. (Don't ask me why it just doesn't feel right) |
@JimBobSquarePants I think you have this feeling because all of them are returning an |
@antonfirsov Yeah, that describes it well. |
@tocsoft All LGTM. Like that we manage the lifecycle of frames through our API now, preserving valid state for We probably need a gif manipulator example, because the behavior of some functions (eg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy with this. It's come together very well!
…-frames Add Extract/Clone apis for manipulating deconstructing images from from
Prerequisites
Description
This adds the new APIs to
Image<TPixel>
for cloning and extracting frames from an image.New APIs
Image<TPixel>.Clone(int frameIndex)
Image<TPixel>.CloneAs<TPixel2>(int frameIndex)
Image<TPixel>.Extract(int frameIndex)
TODO
should these APIs be members of
Image<T>
ofImageFrameCollection
?i.e. do you call
image.Clone(index)
orimage.Frames.CloneFrame(index)
should the apis have the
Frame
postfix? I feel this depended on if the API lives on the frames collection or the imageresolves #340