Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testproject to net8 and c# to 12 #42

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

stefannikolei
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6fda62) 19% compared to head (9e1388e) 19%.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #42   +/-   ##
==================================
  Coverage    19%   19%           
==================================
  Files         4     4           
  Lines       346   346           
  Branches     85    85           
==================================
  Hits         68    68           
  Misses      278   278           
Flag Coverage Δ
unittests 19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimBobSquarePants
Copy link
Member

We should update all dependencies listed in the props too.

https://github.com/SixLabors/SharedInfrastructure/tree/c6fda622baf2074516a380fdf88ad6f4bde81537/msbuild

@JimBobSquarePants JimBobSquarePants merged commit 4e89295 into SixLabors:main Dec 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants