This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Change method to PUT for Consul health check update according to http… #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
The code uses new request scheme for health check update in Consul 1.x.x. Consul agent now checks for specific HTTP verbs and enforces them for particular endpoint.
Alternate Designs
Use Consul 0.x.x without changes
Why Should This Be In Core?
Using ja-micro with Consul 0.x.x leads to high Consul cluster utilization due to X-Consul-Index permanent updates
Benefits
Decreasing Consul cluster load and RAFT database replication rate
Possible Drawbacks
N/A
Applicable Issues
Internal issue