Fix symlinks (relative link, argument order, folder creation) #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was completely broken basically: - No parent directories were created - The link target was wrong and not a local path - The symlink function was called with source and target swapped (this is a documentation bug in the symlink crate tho)
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 64.73% 63.80% -0.93%
==========================================
Files 17 17
Lines 621 630 +9
==========================================
Hits 402 402
- Misses 219 228 +9
|
|
Can you give me the command you used to test this? |
|
Basically any phpBB forum will do. |
Skallwar
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was completely broken basically:
bug in the symlink crate tho)