Add event-item and event-slot to Resurrect Event #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue #5625 |
AyhamAl-Ali
approved these changes
May 7, 2023
AyhamAl-Ali
added
the
enhancement
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
TheLimeGlass
requested changes
May 26, 2023
src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Outdated
Show resolved
Hide resolved
Remove unnecessary event-value
Moderocky
approved these changes
Jun 25, 2023
TheLimeGlass
approved these changes
Jun 28, 2023
Moderocky
pushed a commit
to Moderocky/Skript
that referenced
this pull request
Sep 16, 2023
NotSoDelayed
pushed a commit
to NotSoDelayed/Skript
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an ItemStack and Slot event-values to the Entity Resurrect event. They return the item/slot used in the event (ie: the totem consumed). If no totem is present (and the event is therefore cancelled), the values will be null. Tested on both players and zombies.
Also removes the class existence checks because Skript now targets 1.13+.
Target Minecraft Versions:
Requirements:
Related Issues: #5625