Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity transform events #5800

Merged
merged 16 commits into from
Jan 1, 2024
Merged

Entity transform events #5800

merged 16 commits into from
Jan 1, 2024

Conversation

TheLimeGlass
Copy link
Collaborator

Description

Entity transform events


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@TheLimeGlass TheLimeGlass added the feature Pull request adding a new feature. label Jul 8, 2023
@TheLimeGlass TheLimeGlass marked this pull request as draft July 8, 2023 06:39
@TheLimeGlass TheLimeGlass marked this pull request as ready for review July 10, 2023 00:06
@Moderocky Moderocky changed the base branch from master to dev/feature September 17, 2023 08:02
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of the issues with the patterns, none of the events I tried worked in testing. I listened to the EntityTransformEvent via skript reflect to make sure, and it was called every time. None of the skript events triggered:

[23:54:12 INFO]: [Skript] Server Version: git-Paper-17 (MC: 1.20)
[23:54:12 INFO]: [Skript] Skript Version: 2.7.0-beta3-nightly-6356c75 (skriptlang-nightly)
[23:54:12 INFO]: [Skript] Installed Skript Addons:
[23:54:12 INFO]: [Skript]  - skript-reflect v2.4-dev1 (https://github.com/TPGamesNL/skript-reflect)
[23:54:12 INFO]: [Skript] Installed dependencies:
[23:54:12 INFO]: [Skript]  - WorldGuard v7.0.9+5934e49
on lightning:
    broadcast "lightning"

on unknown:
    broadcast "unknown"

on mooshroom transform:
    broadcast "sheared"

on zombie curing:
    broadcast "cured"

on zombie, skeleton or slime transform:
    broadcast "transformed"

import:
    org.bukkit.event.entity.EntityTransformEvent

on EntityTransformEvent:
    broadcast "transformed"
    broadcast " - %event.getTransformReason()%"

image
image

src/main/resources/lang/default.lang Outdated Show resolved Hide resolved
src/main/resources/lang/default.lang Outdated Show resolved Hide resolved
TheLimeGlass and others added 3 commits October 18, 2023 03:09
Co-authored-by: Ayham Al Ali <20037329+AyhamAl-Ali@users.noreply.github.com>
Co-authored-by: Shane Bee <shanebolenback@me.com>
Co-authored-by: Shane Bee <shanebolenback@me.com>
Copy link
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one tiny thing left

Co-authored-by: Shane Bee <shanebolenback@me.com>
src/main/resources/lang/default.lang Outdated Show resolved Hide resolved
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
@sovdeeth sovdeeth added 2.8 Targeting a 2.8.X version release feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Dec 30, 2023
@sovdeeth sovdeeth merged commit 4291e5b into dev/feature Jan 1, 2024
5 checks passed
@sovdeeth sovdeeth deleted the feature/transformed branch January 1, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 Targeting a 2.8.X version release feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants