ExprIndices - fix strings not sorting alphabetically #6495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about mimicking the comparison behavior of ExprSortedList? |
I could probably do something like that, altho that doesn't ignore cases in strings UPDATE: Took Ted's suggestion, and mildly updated ExprSortedList as well |
AyhamAl-Ali
added
bug
|
Tests needs to be fixed 😬 |
AyhamAl-Ali
approved these changes
Mar 17, 2024
sovdeeth
approved these changes
Mar 25, 2024
AyhamAl-Ali
added
the
patch-ready
Moderocky
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the alphabetically sorted issue with the sorted indices expression.
NOTE:
This changes the behaviour of ExprSortedList by sorting alphabetically ignoring case.
Previous:
NEW:
Target Minecraft Versions: any
Requirements: none
Related Issues: none #6492