Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #104 #105

Merged
merged 3 commits into from
Sep 7, 2022
Merged

fixed #104 #105

merged 3 commits into from
Sep 7, 2022

Conversation

wuwen5
Copy link
Contributor

@wuwen5 wuwen5 commented Sep 7, 2022 •
edited
Loading

fixed #104

image

wuwen5 referenced this pull request Sep 7, 2022
@wbpcode
use proto span object to store span info directly to avoid uncessary …
e5d747f 
…copies (#94)
@wuwen5
Copy link
Contributor Author

wuwen5 commented Sep 7, 2022 •
edited
Loading

It may be broken here

e5d747f#diff-c36c7b341b8772cdeb7c6252bd87482837ed9e287897fee7a64929b2b5bca36dR142

@wbpcode

@wu-sheng
Copy link
Member

wu-sheng commented Sep 7, 2022

@wuwen5 You break the CI.

@wu-sheng wu-sheng added the bug Something isn't working label Sep 7, 2022
@wu-sheng wu-sheng added this to the 0.6.0 milestone Sep 7, 2022
@wbpcode
Copy link
Contributor

wbpcode commented Sep 7, 2022

And I think we should a test case to guard it. Thanks.

@wbpcode wbpcode mentioned this pull request Sep 7, 2022
Closed
@wu-sheng wu-sheng modified the milestones: 0.6.0, 0.5.1 Sep 7, 2022
@wuwen5
Copy link
Contributor Author

wuwen5 commented Sep 7, 2022 •
edited
Loading

cpp2sky test / e2e-python (pull_request) Failing
This may be a network problem, The previous tests were all good.
I changed the code format for the last time

@wu-sheng wu-sheng merged commit 04916eb into SkyAPM:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@wbpcode wbpcode Awaiting requested review from wbpcode

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.

The cpp server trace is always broken
3 participants
@wuwen5 @wu-sheng @wbpcode