-
Notifications
You must be signed in to change notification settings - Fork 33
feat: add reporter plugins: kafka sarama #33
Conversation
You can't do through mock collector, but we have e2e framework for this. An example in Java repo, https://github.com/apache/skywalking-java/blob/main/.github/workflows/e2e.yaml. |
@matianjun1 Please add license header |
How about use |
For golang package names. I agree with using |
How about |
@matianjun1 You need to activate kafka-fetcher. |
@arugal And using But the oap server still not receive trace messages. |
@matianjun1 The e2e failed because the service was not found, please see here #33 (comment) |
service will be report to kafka by Boot. |
@matianjun1 I have sent an email to mtj334510983@163.com, please check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace range with contains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@matianjun1 thank you, this is about your contribution. https://twitter.com/ASFSkyWalking/status/1447230491128582150 |
add kafka reporter just like SkyWalking Python Agent implement
e2e test cant do because of thats for grpc