Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Don't crash if a team is a reviewer #75

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

jerry-skydio
Copy link
Collaborator

@jerry-skydio jerry-skydio commented Oct 12, 2022

Adding full team support looks like a medium task,
but for now we can at least not crash.

Topic: teams
Reviewers: brian-k
closes #73

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Oct 12, 2022

Reviews in this chain:
#75 github: Don't crash if a team is a reviewer

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Oct 12, 2022

# head base diff date summary
0 7dbeb285 4b357f91 diff Oct 12 2:06 PM 1 file changed, 4 insertions(+)
1 40148f6f d932439f diff Oct 13 18:43 PM 1 file changed, 8 insertions(+), 2 deletions(-)
2 33f503ce d932439f diff Oct 13 18:48 PM 1 file changed, 4 insertions(+), 7 deletions(-)

@jerry-skydio jerry-skydio requested a review from a team October 12, 2022 21:07
@jerry-skydio jerry-skydio changed the title github: Allow teams to be specified in Reviewers github: Don't crash if a team is a reviewer Oct 14, 2022
Adding full team support looks like a medium task,
but for now we can at least not crash.

Topic: teams
Reviewers: brian-k
closes #73
Copy link

@brian-kubisiak-skydio brian-kubisiak-skydio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nvm, see you don't want to add the team as a reviewer just yet.

@jerry-skydio jerry-skydio merged commit ea42222 into main Oct 14, 2022
@jerry-skydio jerry-skydio deleted the jerry/revup/main/teams branch October 14, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revup explodes on PRs with team reviewer
2 participants