Should allow create conversation with user record and id

[carmenlau]

Expected Results

In js sdk, user should be able to create chat with user record or id, so all of the following call should be valid.

await skygearChat.createDirectConversation(user._id, null)
await skygearChat.createDirectConversation(user, null)
await skygearChat.createDirectConversation(user.id, null)

Actual Results

• Create conversation correctly

  await skygearChat.createDirectConversation(user._id, null)
  

• Got invalid user error

  await skygearChat.createDirectConversation(user, null)
  

• Always creating conversation successfully which is incorrect, should have duplicate conversation error when creating for the second time

  await skygearChat.createDirectConversation(user.id, null)
  

Example

To test it in js:

const user = (await skygear.publicDB.query(new skygear.Query(skygear.UserRecord).contains('username', ['user1'])))[0]
await skygearChat.createDirectConversation(user, null)