disabled color #177
Merged
disabled color #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kanjanaSi this looks really neat :) Can you post some screenshots of this as well? |
k0nserv
suggested changes
Oct 26, 2017
| attributedPlaceholder = NSAttributedString( | ||
| string: placeholder, | ||
| attributes: [ | ||
| NSAttributedStringKey.foregroundColor: color, NSAttributedStringKey.font: font |
There was a problem hiding this comment.
Please cleanup this indentation to match what it was before.
kanjanaSi
force-pushed
the
disabled-color
branch
from
0a09b2e
to
76602eb
Compare
|
Awesome :) Would you be up for updating the README.md with documentation and the example project? |
kanjanaSi
force-pushed
the
disabled-color
branch
from
76602eb
to
6b06fe3
Compare
|
This control is confusing
It seems to be doing the opposite for me i.e when it's "disabled" the text fields is actually enabled and vice versa |
k0nserv
reviewed
Oct 26, 2017
|
@k0nserv Hi Hugo. Do you have any plan to release this? I was ready to implement this feature and I just found out this PR. |
|
Hey @zarzonis yeah I'll do that right away :) |
k0nserv
approved these changes
Nov 1, 2017
|
That's it released. Thanks a bunch @kanjanaSi for the awesome contribution 🎉 |
|
🎉🎉🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.