[BPKBarChart] ACC-455/ACC-456 Resolve Accessibility defects #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,6 @@ internal final class BPKBarChartCollectionViewCell: UICollectionViewCell { | |||
| lazy public var barChartBar: BPKBarChartBar = { | |||
| let view: BPKBarChartBar = BPKBarChartBar() | |||
| view.translatesAutoresizingMaskIntoConstraints = false | |||
| view.isUserInteractionEnabled = false | |||
There was a problem hiding this comment.
This would add 'dimmed' to the barchart read out for each bar
| @@ -20,10 +20,10 @@ import UIKit | |||
|
|
|||
| @objcMembers | |||
| @objc(BPKBarChartBar) | |||
| public final class BPKBarChartBar: UIControl { | |||
| public final class BPKBarChartBar: UIView { | |||
There was a problem hiding this comment.
Make the bar a simple UIView, we only used UIControl to facilitate isSelected as a property
There was a problem hiding this comment.
Any cons in leaving this a UIControl? Given is an intractable element and UIControl inherits from UIView, seems alright to leave it like that?
There was a problem hiding this comment.
The problem is that we then need to set userInteractionEnabled = false on it, to allow selection of the cell.
There was no point in having it as a UIControl, if we do and disable interaction it will announce as disabled :/
mcomisso
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BPKBarChart
Remember to include the following changes:
README.mdBackpack.hheader fileIf you are curious about how we review, please read through the code review guidelines