-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOOM-1281 BpkDialog className moved to new wrapper span #3325
Conversation
console.warn('BpkDialog: dismissible is true but no onClose prop was provided. Dialog will not be dismissible.'); | ||
console.warn( | ||
'BpkDialog: dismissible is true but no onClose prop was provided. Dialog will not be dismissible.', | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier changed these lines here
@@ -32,11 +32,13 @@ | |||
|
|||
&__close-button { | |||
float: right; | |||
margin: 0 0 tokens.bpk-spacing-base() tokens.bpk-spacing-base(); | |||
margin: 0 calc(tokens.bpk-spacing-sm() / 2) tokens.bpk-spacing-base() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter required using calc
or math.div
for division
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, in another PR this wasn't needed and could be done via a variable: https://github.com/Skyscanner/backpack/pull/3320/files#r1542792398
Maybe we want to work on aligning and having a consistent approach throughout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in slack thread, discovered that the other PR's change does have the same linter warnings so changing this to a variable will not do anything to solve that problem
Visit https://backpack.github.io/storybook-prs/3325 to see this build running in a browser. |
I have verified this change manually locally on storybook compared to a previous build, but I've just realised that there are no Percy tests for bpk-component-dialog Edit: No visual tests is OK, it is because this component requires a click to see |
Visit https://backpack.github.io/storybook-prs/3325 to see this build running in a browser. |
Part of work moving className usage out of backpack components.
Moved className from BpkCloseButton out to wrapper span, adjusted margins slightly to compensate shift
Remember to include the following changes:
[KOA-123][BpkButton] Updating the colour
README.md
(If you have created a new component)README.md
.d.ts
) files updated