Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update condition handling for IpAddress #73

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Update condition handling for IpAddress #73

merged 2 commits into from
Aug 11, 2021

Conversation

ocrawford555
Copy link
Contributor

@ocrawford555 ocrawford555 commented Aug 11, 2021 •
edited
Loading

Update condition handling for IpAddress to handle IPv*Network comparison with subnet_of method.

@ocrawford555 ocrawford555 marked this pull request as ready for review August 11, 2021 14:06
@ocrawford555
Copy link
Contributor Author

Discussed with @oscarbc96, turns out in CF it needs to be in CIDR format.

The value must be in the standard CIDR format (for example, 203.0.113.0/24 or 2001:DB8:9234:5678::/64). If you specify an IP address without the associated routing prefix, IAM uses the default prefix value of /32.

This means we only need to support IPv*Network comparison. Updating code (and tests!) now to reflect that.

@ocrawford555 ocrawford555 changed the title WIP: Update condition handling for IpAddress Update condition handling for IpAddress Aug 11, 2021
oscarbc96
oscarbc96 approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@oscarbc96 oscarbc96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@ocrawford555 ocrawford555 merged commit ce6e108 into master Aug 11, 2021
@ocrawford555 ocrawford555 deleted the update-conditions-ipaddress branch January 12, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmendez xmendez xmendez approved these changes

@oscarbc96 oscarbc96 oscarbc96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ocrawford555 @xmendez @oscarbc96