Ykeremy/bitwarden use search instead of url filter #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do we introduce a new library: [`tldextract`](https://github.com/john-kurkowski/tldextract)? > tldextract accurately separates a URL's subdomain, domain, and public suffix, using [the Public Suffix List (PSL)](https://publicsuffix.org/). > > Say you want just the "google" part of https://www.google.com/. Everybody gets this wrong. Splitting on the "." and taking the 2nd-to-last element only works for simple domains, e.g. .com. Consider http://forums.bbc.co.uk/: the naive splitting method will give you "co" as the domain, instead of "bbc". Rather than juggle TLDs, gTLDs, or ccTLDs yourself, tldextract extracts the currently living public suffixes according to [the Public Suffix List](https://publicsuffix.org/). > > A "public suffix" is one under which Internet users can directly register names. > > A public suffix is also sometimes called an effective TLD (eTLD).⚠️ > Beware when first calling tldextract, it updates its TLD list with a live HTTP request.
Why do we introduce a new library: [`tldextract`](https://github.com/john-kurkowski/tldextract)? > tldextract accurately separates a URL's subdomain, domain, and public suffix, using [the Public Suffix List (PSL)](https://publicsuffix.org/). > > Say you want just the "google" part of https://www.google.com/. Everybody gets this wrong. Splitting on the "." and taking the 2nd-to-last element only works for simple domains, e.g. .com. Consider http://forums.bbc.co.uk/: the naive splitting method will give you "co" as the domain, instead of "bbc". Rather than juggle TLDs, gTLDs, or ccTLDs yourself, tldextract extracts the currently living public suffixes according to [the Public Suffix List](https://publicsuffix.org/). > > A "public suffix" is one under which Internet users can directly register names. > > A public suffix is also sometimes called an effective TLD (eTLD).⚠️ > Beware when first calling tldextract, it updates its TLD list with a live HTTP request.
Why do we introduce a new library: [`tldextract`](https://github.com/john-kurkowski/tldextract)? > tldextract accurately separates a URL's subdomain, domain, and public suffix, using [the Public Suffix List (PSL)](https://publicsuffix.org/). > > Say you want just the "google" part of https://www.google.com/. Everybody gets this wrong. Splitting on the "." and taking the 2nd-to-last element only works for simple domains, e.g. .com. Consider http://forums.bbc.co.uk/: the naive splitting method will give you "co" as the domain, instead of "bbc". Rather than juggle TLDs, gTLDs, or ccTLDs yourself, tldextract extracts the currently living public suffixes according to [the Public Suffix List](https://publicsuffix.org/). > > A "public suffix" is one under which Internet users can directly register names. > > A public suffix is also sometimes called an effective TLD (eTLD).⚠️ > Beware when first calling tldextract, it updates its TLD list with a live HTTP request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we introduce a new library:
tldextract?