fix no exist artifact read #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to f5d5856 in 10 seconds
More details
- Looked at
39lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_I4KvBLIUumSm6a5n
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| try: | ||
| with open(path, "rb") as f: | ||
| browser_state.browser_artifacts.video_artifacts[i].video_data = f.read() | ||
| if path and os.path.exists(path=path): |
There was a problem hiding this comment.
os.path.exists should be called with path as a positional argument, not a keyword argument. This applies here and on line 146 as well.
Suggested change
| if path and os.path.exists(path=path): | |
| if path and os.path.exists(path): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Improved file existence checks in
get_video_artifactsandget_har_datainskyvern/webeye/browser_manager.pyto handle non-existent artifact files gracefully.Key points:
get_video_artifactsinskyvern/webeye/browser_manager.pyto check ifvideo_pathexists before reading.FileNotFoundErrorexception handling inget_video_artifacts.get_har_datainskyvern/webeye/browser_manager.pyto check ifhar_pathexists before reading.Generated with ❤️ by ellipsis.dev