add async http client #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to e9972e7 in 19 seconds
More details
- Looked at
31lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_4Knirns100YwaJCk
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| A wrapper of httpx client. | ||
| Functionalities: | ||
| 1. It comes with a default httpx.AsyncClient instance. | ||
| 2. The httx client could be replaced by a set_client method. |
There was a problem hiding this comment.
The docstring mentions a set_client method, but it is not implemented. Either implement this method or update the docstring to reflect the current functionality.
| """ | ||
|
|
||
| def __init__(self, proxy: str | None = None) -> None: | ||
| self.client = httpx.AsyncClient(proxy=proxy) |
There was a problem hiding this comment.
The proxy parameter should be proxies in httpx.AsyncClient.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces
AsyncHttpClientusinghttpxfor asynchronous HTTP requests with GET, POST methods, proxy support, and asynchronous closing.Key points:
AsyncHttpClientinskyvern/forge/sdk/core/async_http_client.py.httpx.AsyncClientfor asynchronous HTTP requests.getandpostmethods for making requests.closemethod to close the client asynchronously.Generated with ❤️ by ellipsis.dev