Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - Better table handling #70

Closed
spiritualgeek opened this issue Feb 19, 2022 · 14 comments
Closed

[FR] - Better table handling #70

spiritualgeek opened this issue Feb 19, 2022 · 14 comments
Assignees
Labels
enhancement New feature or request

Comments

@spiritualgeek
Copy link

I'd be very appreciative if you'd consider exposing the following to the Style settings plugin:

  • A maximum size that any column can be
  • font size for <td>
  • font size for <th>
  • Options to minimize (or completely remove) padding

Dataview tables should work in the same fashion and this should be consistent between reading view and live preview modes (i.e., look exactly the same)

Thanks for a wonderful theme

@spiritualgeek spiritualgeek added the enhancement New feature or request label Feb 19, 2022
@SlRvb
Copy link
Owner

SlRvb commented Feb 20, 2022

A maximum size that any column can be

I'm a bit unsure what this would be, do you want css classes to resize specific columns or general style settings options to just have columns span the whole note?


Options to minimize (or completely remove) padding

For td and th separately?

@spiritualgeek
Copy link
Author

Maybe my explanation is really horrid :)

  • The ability to set the font size for cell content
  • The ability to set the font size for heading content
  • The ability to set the max width that any column can be. So, a column with long text doesn't destroy the table by squashing all other columns
  • The ability to remove padding when it comes to borders, the actual cell etc. So that the maximum amount of text can fit inside the table
  • The ability to do the above for dataview and normal tables.

I hope that this makes more sense?

@SlRvb
Copy link
Owner

SlRvb commented Feb 20, 2022

Ah yep, that clears it up perfectly, thanks! I'll see what I can do 🙂

@spiritualgeek
Copy link
Author

I keep on coming back to your theme. Thank you for the immense effort you put in to keep these theme fresh and to solve little issues

@SlRvb
Copy link
Owner

SlRvb commented Feb 21, 2022

font size for
font size for
Options to minimize (or completely remove) padding

So I've managed to do these three: 5baba8c. Should find the sliders under Note Elements > Tables.


I'm a bit unsure as of right now how to get max width to work in tables. Not even fully sure max width works in table cells at least in the way you'd want it to work 😔

@spiritualgeek
Copy link
Author

It seems to work a treat :) I can't seem to find the font sizing though?

This was fast. Thank you so much

@SlRvb
Copy link
Owner

SlRvb commented Feb 21, 2022

Oops, forgot to commit those changes 🤦‍♀️

I've rearranged some stuff and made the settings a little more visually distinct. Also actually added the td and th changes 😅 e0c12b1

Obsidian_ZaGELXPi29

@spiritualgeek
Copy link
Author

This works perfectly. Thanks so much!

Just 1 last request. It would be great if it carried across the note text weight.

Or perhaps even had its own :)

Thank you so much. This is outstanding. Highly appreciative.

@SlRvb
Copy link
Owner

SlRvb commented Feb 21, 2022

Just 1 last request. It would be great if it carried across the note text weight.

What do you mean? 🤔

@spiritualgeek
Copy link
Author

If one changes the note text weight to be a bit heavier it has no impact on the text in the table which it should. Otherwise, a separate font-weight just for tables would be good :)

@SlRvb
Copy link
Owner

SlRvb commented Feb 22, 2022

Oooh, interesting. I hadn't noticed that, will fix for both 👍🏽

@spiritualgeek
Copy link
Author

.poke :)

@SlRvb
Copy link
Owner

SlRvb commented Mar 8, 2022

Oops, so I think I've added support for that here under the Note Elements > Tables 8f3d8e2

@spiritualgeek
Copy link
Author

How did I miss that? :) Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants