adding functionality for azure default, and managed identity login #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, As mentioned in the Issue report #21, we had a use-case where we wanted to use this tap, but wanted to avoid the use of service principals if possible.
This PR includes our proposed changes to the Authenticator property of the RESTStream -> MMSGraphStream.
We have added the property
managed_identity
to the config, and setclient_id
andclient_secret
torequired=False
to support additional authentication methods.tenant
remains required.The logic now is such:
client_id
andclient_secret
are set use the original authentication method, thus maintaining backwards compatibility.managed_identity
is set, it will use Azure.ManagedIdentityCredentialsclient_id
,client_secret
ormanaged_identity
are set it will use Azure.DefaultCredentials.We hope you will accept these changes. Tests to confirm the behaviour ar included.
Let us know if there is anything you want us to adjust.