Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension build on linux #5

Closed
lassoan opened this issue Jul 9, 2018 · 5 comments
Closed

Fix extension build on linux #5

lassoan opened this issue Jul 9, 2018 · 5 comments
Assignees

Comments

@lassoan
Copy link
Contributor

lassoan commented Jul 9, 2018

On Linux platforms, xeus also requires libuuid, which is available in all linux distributions (uuid-dev on Debian). This package should be installed on factory machines.

@ihnorton
Copy link
Member

@jcfr @sjh26 could you please add this package to the build system? There are other packaging issues on linux, which I can take care of, but I don't have any way to fix the build right now. I would like to make the mybinder image refresh automatically every few days, and the simplest way to do that is to use the existing SlicerPreview packages.

@jcfr
Copy link
Member

jcfr commented Oct 17, 2018

For linux, it is a matter of updating this file: Docker/qt5-centos7/Dockerfile. See Slicer/SlicerBuildEnvironment#9

That said, since libuuid-devel provides the shared library libuuid.so, should we package it or expect it to be available on every target system ? Installing libuuid could also be a prerequisite on linux.

$ sudo repoquery -l libuuid-devel
/usr/include/uuid
/usr/include/uuid/uuid.h
/usr/lib/libuuid.so
/usr/lib/pkgconfig/uuid.pc
/usr/share/doc/libuuid-devel-2.23.2
/usr/share/doc/libuuid-devel-2.23.2/COPYING
/usr/share/man/man3/uuid.3.gz
[...]
/usr/include/uuid
/usr/include/uuid/uuid.h
/usr/lib64/libuuid.so
/usr/lib64/pkgconfig/uuid.pc
/usr/share/doc/libuuid-devel-2.23.2
/usr/share/doc/libuuid-devel-2.23.2/COPYING
/usr/share/man/man3/uuid.3.gz
[...]

@ihnorton
Copy link
Member

If we make it a prerequisite, we should put it on the main Slicer dep list rather than needing another specific step for SlicerJupyter.

Considering it is hard to get software installed on HPC-like systems, I would lean a bit towards packaging. It only links libc so it should be safe enough to redistribute (at least as safe as packaging libssl).

@ihnorton ihnorton mentioned this issue Oct 19, 2018
4 tasks
@ihnorton
Copy link
Member

Looks like this is fixed?

http://slicer.cdash.org/index.php?project=SlicerPreview&date=2018-11-18&filtercount=1&showfilters=1&field1=label&compare1=63&value1=SlicerJupyter

(today's build failed but looks like it was just a network issue)

@lassoan
Copy link
Contributor Author

lassoan commented Dec 11, 2018

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants