Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Prefer using lowercase to name package #162

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

jhlegarreta
Copy link
Contributor

Prefer using lowercase to name package in line with other relevant scientific computing Python packages.

Change it as well in the commented PyPI URL (note that the package was never been uploaded to PyPI, and thus, changing the package name at this stage is safe from that point of view).

Prefer using lowercase to name package in line with other relevant
scientific computing Python packages.

Change it as well in the commented PyPI URL (note that the package was
never been uploaded to PyPI, and thus, changing the package name at this
stage is safe from that point of view).
@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Oct 5, 2023

Cross-referencing #154 (comment).

I assume this has no impact on the package being available as a 3D Slicer module.

Copy link
Member

@ljod ljod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@ljod ljod merged commit 669c238 into SlicerDMRI:master Oct 5, 2023
1 check passed
@jhlegarreta jhlegarreta deleted the PackageNameToAllLowerCase branch October 5, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants