-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display SlimeVR Tracker Battery Life #41
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SlimeVR-specific tracker icons to be used, removed old icons which were unused.
Co-authored-by: Butterscotch! <bscotchvanilla@gmail.com>
Added support for trackers reporting: - Battery percentage - When charging (Battery voltage >=4.2V; guesstimate, maybe needs to be changed)
The only thing battery voltage is used for here is for detecting if the tracker is charging or not, correct? I'd rather kick charging detection into firmware (or at least server for now) (i.e. the device reports the right thing depending on the setup) and just receive a boolean is_charging in driver. |
Replaced battery_voltage with is_charging, and added sending HMD battery to server.
SteamVR applies a blue-green gradient to tracker icons at runtime and creates a ".b4bfb144" version if one is not present. Blue-green ".b4bfb144" tracker icons do already exist and therefore these are used instead of SteamVR generating redundant ".b4bfb144.b4bfb144" icons.
kitlith
approved these changes
May 22, 2023
ButterscotchV
added
Type: Enhancement
Adds or improves a feature
Priority: Normal
The default priority
labels
May 27, 2023
Eirenliel
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for receiving tracker battery info from the SlimeVR Server.
This depends on another pull request. (SlimeVR/SlimeVR-Server#668)